fix: migrate list component to Svelte 5 runes syntax#3010
Open
abhay-dev2901 wants to merge 2 commits intoappwrite:mainfrom
Open
fix: migrate list component to Svelte 5 runes syntax#3010abhay-dev2901 wants to merge 2 commits intoappwrite:mainfrom
abhay-dev2901 wants to merge 2 commits intoappwrite:mainfrom
Conversation
Contributor
Greptile SummaryMigrates Confidence Score: 5/5Safe to merge — single-file change with a straightforward Svelte 4→5 migration and no logic changes. No P0 or P1 findings. The runes migration is correct, No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "Resolved comments" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the
list.sveltecomponent to use Svelte 5 runes syntax. The project is already running Svelte 5, but this component was still using the oldexport letsyntax.Changes:
export let childrentolet { children }: { children?: Snippet } = $props(){@render children?.()}instead of the old slot syntaxgap: 0.25rem)Test Plan
I tested this by:
To test yourself:
bun run devRelated PRs and Issues
This is part of the effort to clean up the remaining ~500 files that still use legacy Svelte 4 syntax.
Have you read the Contributing Guidelines on issues?
Yes.